----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52153/#review150062 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/openssl.cpp (line 493) <https://reviews.apache.org/r/52153/#comment217870> I recall that we prefer `.at(...)` even when there's an existence check directly preceeding the map access. 3rdparty/libprocess/src/openssl.cpp (line 501) <https://reviews.apache.org/r/52153/#comment217871> Ditto here. - Joseph Wu On Sept. 22, 2016, 2:43 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52153/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 2:43 a.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-5320 > https://issues.apache.org/jira/browse/MESOS-5320 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.cpp > c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 > > Diff: https://reviews.apache.org/r/52153/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
