----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52145/#review150074 -----------------------------------------------------------
src/launcher/default_executor.cpp (line 356) <https://reviews.apache.org/r/52145/#comment217889> How about add a INFO level log for the agent URL? I saw that the `executor.cpp` also do not have the URL in log message, but I think it make sense to adding such debug log. - Guangya Liu On 九月 22, 2016, 7:15 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52145/ > ----------------------------------------------------------- > > (Updated 九月 22, 2016, 7:15 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6227 > https://issues.apache.org/jira/browse/MESOS-6227 > > > Repository: mesos > > > Description > ------- > > This change adds support for populating the agent API URL needed > for making the calls for launching/waiting/killing > child containers. Ideally, we should have used the > `MESOS_AGENT_ENDPOINT` variable but that is a bit hard > to do with our testcase setup that generates the > agent process ID. > > > Diffs > ----- > > src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c > > Diff: https://reviews.apache.org/r/52145/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
