> On 九月 22, 2016, 10:02 p.m., Zhitao Li wrote:
> > src/cli/execute.cpp, line 270
> > <https://reviews.apache.org/r/51623/diff/7/?file=1502985#file1502985line270>
> >
> >     Does this work when `--task_group` is not specified? It seems to cause 
> > segfault.

Can you show more detail for your command which caused the segfault? I think 
that we alraedy have some check here 
https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L767-L792


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/#review150079
-----------------------------------------------------------


On 九月 19, 2016, 7:45 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51623/
> -----------------------------------------------------------
> 
> (Updated 九月 19, 2016, 7:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Through this patch, mesos-execute supports running
> task groups. Single task provided through command
> line option is supported as well for backward
> compatibility.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 
> 
> Diff: https://reviews.apache.org/r/51623/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4
> 
> and manually ran this command:
> **Successful**
> mesos-execute --master=127.0.0.1:5050 
> --taskgroup=file:///home/abhishek/taskgroup.txt
> 
> `/home/abhishek/taskgroup.txt:`
> {
>       "tasks": [{
>               "name": "sigmtdroid",
>               "task_id": {
>                       "value": "sigmoid"
>               },
>               "agent_id": {
>                       "value": ""
>               },
>               "resources": [{
>                       "name": "cpus",
>                       "type": "SCALAR",
>                       "scalar": {
>                               "value": 1
>                       },
>                       "role": "*"
>               }, {
>                       "name": "mem",
>                       "type": "SCALAR",
>                       "scalar": {
>                               "value": 32
>                       },
>                       "role": "*"
>               }],
>               "command": {
>                       "value": "sleep 1000"
>               },
>               "volumes": [{
>                       "container_path": "/mnt/volume",
>                       "mode": "RW",
>                       "source": {
>                               "docker_volume": {
>                                       "driver": "volume_driver",
>                                       "docker_options": {
>                                               "parameter": [{
>                                                       "key": "key",
>                                                       "value": "value"
>                                               }]
>                                       },
>                                       "name": "volume_name"
>                               },
>                               "type": "DOCKER_VOLUME"
>                       }
>               }]
>       }, {
>               "name": "sigmteroid",
>               "task_id": {
>                       "value": "sigmoid2"
>               },
>               "agent_id": {
>                       "value": ""
>               },
>               "resources": [{
>                       "name": "cpus",
>                       "type": "SCALAR",
>                       "scalar": {
>                               "value": 2
>                       },
>                       "role": "*"
>               }, {
>                       "name": "mem",
>                       "type": "SCALAR",
>                       "scalar": {
>                               "value": 32
>                       },
>                       "role": "*"
>               }],
>               "command": {
>                       "value": "sleep 1000"
>               },
>               "volumes": [{
>                       "container_path": "/mnt/volume",
>                       "mode": "RW",
>                       "source": {
>                               "docker_volume": {
>                                       "driver": "volume_driver",
>                                       "docker_options": {
>                                               "parameter": [{
>                                                       "key": "key",
>                                                       "value": "value"
>                                               }]
>                                       },
>                                       "name": "volume_name"
>                               },
>                               "type": "DOCKER_VOLUME"
>                       }
>               }]
>       }]
> }
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to