-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52177/#review150143
-----------------------------------------------------------




src/cli/execute.cpp (lines 468 - 478)
<https://reviews.apache.org/r/52177/#comment218013>

    I don't follow this change. Can the TaskGroupInfo JSON not contain the 
NetworkInfos? Why do have to specify it via `--networks`?



src/cli/execute.cpp (line 788)
<https://reviews.apache.org/r/52177/#comment218014>

    Infact `--networks` should not be specified if `--task_group` is specified. 
We need to add `flags.networks` here.


- Vinod Kone


On Sept. 22, 2016, 9:48 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52177/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:48 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for CNI networks for `--task_group`.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 79091d6dd3e09e354f6965b0da45662621297bee 
> 
> Diff: https://reviews.apache.org/r/52177/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Ran `mesos-execute` with the --task_group and --network option with the 
> following POD definition:
> {
>   "tasks":[
>     {
>       "name" : "nginx",
>       "task_id" : {"value":"nginx"},
>       "agent_id": {"value" : ""},
>       "resources": [{
>         "name": "cpus",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 0.1
>         },
>         "role": "*"
>       },
>       {
>         "name": "mem",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 128
>         },
>         "role": "*"
>       }],
>       "container" : {
>         "type" : "MESOS",
>         "mesos" : {
>           "image" : {
>             "type" : "DOCKER",
>             "docker" : {
>               "name" : "nginx"
>             }
>           }
>         }
>       }
>     },
>     {
>       "name" : "redis",
>       "task_id" : {"value":"redis"},
>       "agent_id": {"value" : ""},
>       "resources": [{
>         "name": "cpus",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 0.1
>         },
>         "role": "*"
>       },
>       {
>         "name": "mem",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 128
>         },
>         "role": "*"
>               }],
>       "container" : {
>         "type" : "MESOS",
>         "mesos" : {
>           "image" : {
>             "type" : "DOCKER",
>             "docker" : {
>               "name" : "redis"
>             }
>           }
>         }
>       }
>     }
>   ]
> }
> 
> The pod definition doesn't do much (mesos can't launch docker containers in 
> PODS right now), but the pod itself is attached to a CNI network and it gets 
> an IP address and a network name space of its own.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to