----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52146/#review150146 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp (line 72) <https://reviews.apache.org/r/52146/#comment218015> s/killed/shuttingDown/ - Vinod Kone On Sept. 22, 2016, 7:33 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52146/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 7:33 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This change gets rid of the trivial `killTask()` implementation > and makes it call `shutdown()`. It also gets rid of the existing > `taskGroup` member variable. Eventually, later in the review chain > we would populate these functions to make the actual calls to the > agent. > > > Diffs > ----- > > src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c > > Diff: https://reviews.apache.org/r/52146/diff/ > > > Testing > ------- > > > Thanks, > > Anand Mazumdar > >
