----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52224/#review150268 -----------------------------------------------------------
Ship it! LGTM! - Joseph Wu On Sept. 23, 2016, 1:40 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52224/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 1:40 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Previously, we allowed the posix launcher to specified on windows and > just blindly ignored it and instantiated a windows launcher anyway. > This was likely due to legacy code, not setting the default launcher > properly in flags.cpp. Now that we set the default to "windows" > properly, this hack is no longer needed. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 144b0db501d40d4e0bba12672723616bedd76e7e > > Diff: https://reviews.apache.org/r/52224/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
