----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52065/#review150277 -----------------------------------------------------------
Fix it, then Ship it! I can fix this before committing. 3rdparty/stout/include/stout/os/windows/shell.hpp (lines 101 - 102) <https://reviews.apache.org/r/52065/#comment218175> s/valu/value/ s/was/is/ Surround `_P_WAIT` in backticks. Ditto for the other comments. - Joseph Wu On Sept. 19, 2016, 1:04 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52065/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 1:04 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Fixed warnings in Windows `shell.hpp`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/shell.hpp > 8fb48c1c4178485cac2934833b5c440d873e4fc4 > > Diff: https://reviews.apache.org/r/52065/diff/ > > > Testing > ------- > > Windows: build > > > Thanks, > > Daniel Pravat > >
