> On Sept. 20, 2016, 4:55 p.m., Jie Yu wrote: > > Can you follow up with some tests on this? Should be similar to > > SlaveRecoveryTest. For example: > > 1) start a slave with cgroups/cpu > > 2) launch a task > > 3) stop the slave and start a new one with cgroups/cpu,cgroups/mem > > 4) make sure the old task is ok > > 5) launch a new task, make sure it is ok
The follow up test case is https://reviews.apache.org/r/52243/ - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149676 ----------------------------------------------------------- On Sept. 20, 2016, 1:27 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51631/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 1:27 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6063 > https://issues.apache.org/jira/browse/MESOS-6063 > > > Repository: mesos > > > Description > ------- > > Recover newly added cgroups subsystems on existing containers would > fail, and continue to perform the `update` and other operations of > the newly added subsystems on them don't make sense. This patch add > the tracking for the recovered or prepared cgroups subsystems of a > container and skip performing unnecessary subsystem operations on the > container if the subsystem is never recovered or prepared. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > cf143eef2411b17b775579b1be07c927b64ea835 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 937356b3ef76408bbb01ab699b7a2bd097cdfe82 > > Diff: https://reviews.apache.org/r/51631/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*CGROUPS*" --verbose > ``` > > > Thanks, > > haosdent huang > >
