----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52233/#review150341 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/slave/containerizer.proto (lines 58 - 59) <https://reviews.apache.org/r/52233/#comment218279> I would simply mention this is the container Id. Or, I'll just remove the comment here because it's pretty obviously what this is. include/mesos/slave/containerizer.proto (line 62) <https://reviews.apache.org/r/52233/#comment218280> pid of the init process in the container. - Jie Yu On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52233/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2016, 6:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This is necessary for recovering nested containers, because a list of > 'ContainerState' including recoverable top level containers and nested > containers will be passed to isolator::recover, but there is no way for > nested containers to carry the ExecutorInfo. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 20db010ea158a813034b411111ce9cddac7d8317 > src/common/protobuf_utils.hpp c5e5a9ad10134bcf87b59460bec7152e4916c75d > src/common/protobuf_utils.cpp 5db4be4bdc7b9a3a2a66a17f8a9ac74c8d3dfbf6 > > Diff: https://reviews.apache.org/r/52233/diff/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
