> On Sept. 24, 2016, 9:40 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 492 > > <https://reviews.apache.org/r/52148/diff/3/?file=1508989#file1508989line492> > > > > why VLOG instead of LOG(ERROR)?
hmm, this can happen if the container terminated _just_ before the scheduler sent a `killTask()` for the same container which doesn't neccessarily mean an error condition. I changed it to a `WARNING`. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/#review150315 ----------------------------------------------------------- On Sept. 23, 2016, 3:28 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52148/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 3:28 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6227 > https://issues.apache.org/jira/browse/MESOS-6227 > > > Repository: mesos > > > Description > ------- > > This change implements support for killing child containers via > the `KILL_NESTED_CONTAINER` call on the Agent API. This is > triggered when the executor receives a `KILL`/`SHUTDOWN` > event. Currently, only SIGKILL is supported. Also, the specifying > custom kill policies is not yet supported. > > > Diffs > ----- > > src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c > > Diff: https://reviews.apache.org/r/52148/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
