----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52165/#review150364 -----------------------------------------------------------
Patch looks great! Reviews applied: [52143, 52144, 52164, 52145, 52146, 52147, 52148, 52149, 52165] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 25, 2016, 10:06 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52165/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2016, 10:06 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6227 > https://issues.apache.org/jira/browse/MESOS-6227 > > > Repository: mesos > > > Description > ------- > > This is just a temporary set up to make the ReviewBot happy. > Eventually, when the launcher changes land and we are able to > launch child containers these tests would pass! > > Please note that it is currently a bit hard to unit test > the default executor as we don't have the equivalent of > a `MockMesosContainerizer` that actually launches an > executor. `TestContainerizer` never launches an executor though > we can refactor it to suport v1 executors. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 786fbe3baac3c1542b318a26363213a4a1945ddd > > Diff: https://reviews.apache.org/r/52165/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
