----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150439 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/read.hpp (line 32) <https://reviews.apache.org/r/52196/#comment218427> This should probably be a `CHECK_LE` instead of an assert. 3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 31) <https://reviews.apache.org/r/52196/#comment218434> What's this used for? Is MSVC warning because of the bit shifting (`offset >> 32`) below? 3rdparty/stout/include/stout/os/windows/write.hpp (line 33) <https://reviews.apache.org/r/52196/#comment218433> `CHECK_LE` here too. - Joseph Wu On Sept. 22, 2016, 10:05 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52196/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 10:05 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed warnings in `read/write` functions. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/read.hpp > cb0abf70307f0dbba0b8f68e884df199b0359186 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > 4c5178e1f3696906aa1cf93b8ca450f61ba79355 > 3rdparty/stout/include/stout/os/windows/write.hpp > 705ad03ee58f9cc822ec1ed25fd10f39059717d4 > > Diff: https://reviews.apache.org/r/52196/diff/ > > > Testing > ------- > > OSX: make check > Windows: build > > > Thanks, > > Daniel Pravat > >
