> On Sept. 27, 2016, 1:18 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 213 > > <https://reviews.apache.org/r/52292/diff/1/?file=1510620#file1510620line213> > > > > don't you want to validate multi-level nesting here like you did in > > launch?
The thinking here was to just prevent *the launch* of > 2 level nested containers *for now*. I guess the confusion here is that it's deemed "invalid", so I'll move this to the agent's endpoint and return a 501. Sound good? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52292/#review150504 ----------------------------------------------------------- On Sept. 27, 2016, 12:16 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52292/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 12:16 a.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6241 > https://issues.apache.org/jira/browse/MESOS-6241 > > > Repository: mesos > > > Description > ------- > > Previously, we required that ContainerID.value is a UUID. The > intention here was that each container has the same format, and > we could remove the need for ContainerID.parent since all > ContainerIDs would be unique globally. > > With this change, we intend to keep ContainerID.parent and allow > users to specify custom IDs (e.g. <executor uuid>.redis.backup). > This makes for more readable IDs, and we maintain globally unique > ContainerIDs since the executor container has a UUID generated by > the agent. > > With this change, we now validate that the user supplied IDs are > setting the parent component of the ID correctly, and that the > value does not contain problematic characters. > > > Diffs > ----- > > include/mesos/agent/agent.proto 3397c4177813252b777bbe328ff92c9428366b70 > include/mesos/v1/agent/agent.proto 93c817c0be92f68dea28a9272ac034386ade02af > src/slave/validation.hpp 94286f08ee124753dbac394d9c358fca725be594 > src/slave/validation.cpp 62b273302845dfa2bc1c07d753dfcce122674809 > src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c > src/tests/slave_validation_tests.cpp > ee59aee6d68b518d3263de47d3fe4cfbeb1ab477 > > Diff: https://reviews.apache.org/r/52292/diff/ > > > Testing > ------- > > Updated existing tests and added a ContainerID validation test. > > > Thanks, > > Benjamin Mahler > >
