----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52305/#review150594 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Sept. 27, 2016, 5:58 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52305/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 5:58 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6259 > https://issues.apache.org/jira/browse/MESOS-6259 > > > Repository: mesos > > > Description > ------- > > Removed `CHECK` for no-existent resolv.conf for root containers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 80ce25f5383476500f447570916d1907163ec896 > > Diff: https://reviews.apache.org/r/52305/diff/ > > > Testing > ------- > > Tested with the following pod definition against `mesos-execute: > { > "tasks":[ > { > "name" : "server1", > "task_id" : {"value":"server1"}, > "agent_id": {"value" : ""}, > "resources": [{ > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.1 > }, > "role": "*" > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 128 > }, > "role": "*" > }], > "command" : { > "value" : "python3 -m http.server 9000" > } > }, > { > "name" : "server2", > "task_id" : {"value":"server2"}, > "agent_id": {"value" : ""}, > "resources": [{ > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.1 > }, > "role": "*" > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 128 > }, > "role": "*" > }], > "command" : { > "value" : "python3 -m http.server 10000" > } > } > ] > } > > > Thanks, > > Avinash sridharan > >
