> On Sept. 27, 2016, 3:35 p.m., Gilbert Song wrote: > > src/slave/containerizer/composing.cpp, line 456 > > <https://reviews.apache.org/r/52321/diff/1/?file=1511196#file1511196line456> > > > > just some nits: > > we dont use `'` for containerId in our code.
Drop it. Let's fix it later. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52321/#review150635 ----------------------------------------------------------- On Sept. 27, 2016, 3:25 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52321/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 3:25 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gilbert Song, and > Jie Yu. > > > Bugs: MESOS-6260 > https://issues.apache.org/jira/browse/MESOS-6260 > > > Repository: mesos > > > Description > ------- > > Made composing containerizer nesting aware so that operators > can enable both mesos and docker containerizers on agents. > Ofcourse docker containerizer is not nesting aware. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > 9be780201ec2efae02d560fa3560fe12f1d53a50 > src/slave/containerizer/composing.cpp > 179304a9f0e1e4ef7e2946feea97c0897e24f5ab > src/tests/default_executor_tests.cpp > 3d6cbd92b916f38325f9f23245cc602bae4f83e3 > > Diff: https://reviews.apache.org/r/52321/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Vinod Kone > >
