-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52328/#review150682
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp (line 637)
<https://reviews.apache.org/r/52328/#comment218722>

    false?



src/tests/default_executor_tests.cpp (line 682)
<https://reviews.apache.org/r/52328/#comment218717>

    update2->status().task_id()



src/tests/default_executor_tests.cpp (line 714)
<https://reviews.apache.org/r/52328/#comment218718>

    assert that this is task1?



src/tests/default_executor_tests.cpp (line 718)
<https://reviews.apache.org/r/52328/#comment218719>

    assert TASK_RUNNING ?



src/tests/default_executor_tests.cpp (line 742)
<https://reviews.apache.org/r/52328/#comment218720>

    assert TASK_KILLED



src/tests/default_executor_tests.cpp (line 765)
<https://reviews.apache.org/r/52328/#comment218721>

    assert TASK_KILLED


- Vinod Kone


On Sept. 28, 2016, 4:03 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52328/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6230
>     https://issues.apache.org/jira/browse/MESOS-6230
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a test to verify that we correctly send TASK_KILLED
> updates for all tasks in the task group if any task in the task group
> is reported unhealthy.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 
> 8b5b1a2e69a3b3ca1e2f7881a1be42dafe89c785 
> 
> Diff: https://reviews.apache.org/r/52328/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to