> On Sept. 26, 2016, 11:41 p.m., Anindya Sinha wrote: > > src/slave/containerizer/fetcher.cpp, line 784 > > <https://reviews.apache.org/r/52058/diff/4/?file=1505832#file1505832line784> > > > > I think this should be more like: > > ``` > > if (chownOut.isError() || chownErr.isError()) { > > os::close(out.get()); > > os::close(err.get()); > > return Failure(...); > > } > > ``` > > > > And the `Failure` message can indicate which one failed, ie. `stdout` > > or `stderr` or both (if you want to expose that bit of information).
Moved the error checks for stdout and stderr to different if blocks so we can have custom failure messages for stdout and stderr. - Megha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review150485 ----------------------------------------------------------- On Sept. 28, 2016, 5:10 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52058/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 5:10 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5218 > https://issues.apache.org/jira/browse/MESOS-5218 > > > Repository: mesos > > > Description > ------- > > Fetcher code changes the ownership of entire sandbox directory > recursively to the taskuser and as a resut also changes the > ownership of files laid out by other entities in the sandbox. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 11104d66e6dd05d8eb1d37a2e3250aca19278110 > src/tests/containerizer/mesos_containerizer_tests.cpp > 8b5a19e121ef74eaf99b39682f8fd170605bf56d > > Diff: https://reviews.apache.org/r/52058/diff/ > > > Testing > ------- > > make check on linux > > > Thanks, > > Megha Sharma > >
