----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52105/ -----------------------------------------------------------
(Updated Sept. 28, 2016, 5:56 p.m.) Review request for mesos and Vinod Kone. Changes ------- Fix silly typo in description Bugs: MESOS-6210 https://issues.apache.org/jira/browse/MESOS-6210 Repository: mesos Description (updated) ------- Detect paths starting with `/redirect/` or `/master_id/redirect/` and return 404 instead of getting into a redirect loop. Diffs (updated) ----- src/master/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740 Diff: https://reviews.apache.org/r/52105/diff/ Testing ------- Single Node started with `./src/mesos-master --work_dir=/tmp/mesos` ``` Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:22 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:24 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:26 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:38 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 307 Temporary Redirect < Date: Wed, 28 Sep 2016 17:49:48 GMT < Location: //192.168.1.234:5050 < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/ * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/ HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:50 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect/foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect/foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:51 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact Charless-MacBook-Pro:~ charlesallen$ curl -v http://127.0.0.1:5050/master/redirect_foo * Trying 127.0.0.1... * Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0) > GET /master/redirect_foo HTTP/1.1 > Host: 127.0.0.1:5050 > User-Agent: curl/7.43.0 > Accept: */* > < HTTP/1.1 404 Not Found < Date: Wed, 28 Sep 2016 17:49:54 GMT < Content-Length: 0 < * Connection #0 to host 127.0.0.1 left intact ``` It is worth noting that in this PR /master/redirect/ and /redirect/ return 404, not 307. This behavior is consistent with master. Thanks, Charles Allen