----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52374/#review150792 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Sept. 28, 2016, 5:42 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52374/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 5:42 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-6270 > https://issues.apache.org/jira/browse/MESOS-6270 > > > Repository: mesos > > > Description > ------- > > It is possible that 'destroy' is called before the parent/child > relationship being properly setup. This is because we call > 'container->status->onAny(reaped)` while recovering containers. Since > 'recover' is asynchronous, 'reaped' might be called in the middle, > leading to 'destory' being called. > > This patch defer the registration of 'reaped' callback until > parent/child relationship are properly setup. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > d38de1f48aab2f2932ffa8fbca77eb0290e4f143 > > Diff: https://reviews.apache.org/r/52374/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
