> On Sept. 29, 2016, 12:32 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/getcwd.hpp, line 27 > > <https://reviews.apache.org/r/52210/diff/1/?file=1509031#file1509031line27> > > > > This doesn't seem correct. > > > > `getcwd()` on Posix is: > > ``` > > char *getcwd(char *buf, size_t size); > > ``` > > > > On Windows: > > ``` > > char *_getcwd(char *buffer, int maxlen); > > ``` > > > > So we should be changing the `getcwd()` wrapper in `stout/windows.hpp`.
Missed our re-definition. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/#review150791 ----------------------------------------------------------- On Sept. 23, 2016, 4:48 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52210/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 4:48 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed warnings in getcwd.hpp. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/getcwd.hpp > 63ecc98326a4ba9d78eb0bcec18407c3f4a76de3 > > Diff: https://reviews.apache.org/r/52210/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
