----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/#review150814 -----------------------------------------------------------
Patch looks great! Reviews applied: [52192, 52210, 52364] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 28, 2016, 8:54 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52364/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 8:54 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Used platform specific null device string. > Alled use of `npipe` as `Docker` socket. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb > src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 > src/slave/slave.cpp 7073be44eab6187390922a74cf72facc29bf2ad4 > > Diff: https://reviews.apache.org/r/52364/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >