----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/ -----------------------------------------------------------
(Updated Sept. 29, 2016, 12:07 p.m.) Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos Description ------- Currently, `addSlave()` only adds the used resources of a framework if the framework is currently registered. The same is not true for `addFramework()`: prior to this patch, allocator added used resources of a framework even if the agent is not registered yet. This is currently not broken because Mesos master populates frameworks' used resources based on the registered agents only. However, if we were to call `addFramework()` with resources from unregistered agents (i.e. for which `addSlave()` had not been called), double accounting of resources would occur. Diffs (updated) ----- include/mesos/allocator/allocator.hpp 486b8adc62afaad4c0785702ba43da1f9b655510 src/master/allocator/mesos/hierarchical.cpp 3f51f4194c1ba7c1e4f08c3dd623281ca5754d39 Diff: https://reviews.apache.org/r/43105/diff/ Testing ------- make check Thanks, Alexander Rukletsov
