----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52388/#review150857 -----------------------------------------------------------
Bad review! Reviews applied: [52388, 46825, 46824, 46823] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos ReviewBot On Sept. 29, 2016, 12:55 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52388/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 12:55 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3335 > https://issues.apache.org/jira/browse/MESOS-3335 > > > Repository: mesos > > > Description > ------- > > The base class of the flags hierarchy `FlagsBase` stores a `map` of all > known flags. This make it necessary to only inherit `virtual`ly from > `FlagsBase` (otherwise we would have multiple `map`s and not know > where to look up a certain flag). > > This commit adds a compile-time check to catch cases where users > inherit non-`virual`ly from `FlagsBase`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flags.hpp > eab8a001ed19755de58386a55ed4972f58026b29 > > Diff: https://reviews.apache.org/r/52388/diff/ > > > Testing > ------- > > Tested as part of the review chain ending in > https://reviews.apache.org/r/52388/ on various Linux configurations in > internal CI.. > > > Thanks, > > Benjamin Bannier > >
