----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review151001 -----------------------------------------------------------
Patch looks great! Reviews applied: [51052] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 29, 2016, 8:09 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51052/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 8:09 p.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-6134 > https://issues.apache.org/jira/browse/MESOS-6134 > > > Repository: mesos > > > Description > ------- > > This fixes cpu quota for command executor (which runs outside > of the docker container) by ensuing --cpu-quota flag to docker > run. > > Note: we have to add the boolean variable to `Docker` class > because `Docker::run()` has reached the maximum argument length > GMOCK can support. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 24a6e14fbe5f3aa5b7b7538f33473a564dfbd682 > src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 > src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c > > Diff: https://reviews.apache.org/r/51052/diff/ > > > Testing > ------- > > I am now able to make docker containers launched through mesos-execute have a > cpu quota. > > Also making sure `make check` still works on mac os for the linux only flag. > > > Thanks, > > Zhitao Li > >
