> On Sept. 30, 2016, 3:19 p.m., Benjamin Hindman wrote: > > > > Benjamin Hindman wrote: > FYI, if we factor out `parse` so others can use it as well we won't have > `flags` (so we can't remove `flags.cgroups_root` from the prefix), which is > why this function originally wasn't a `LinuxLauncher` member function and we > removed it before.
Yup, i know :) Yesterday, i was thinking about this and i think we might want to add a 'parse' to paths.hpp|cpp (next to 'buildPath', basically a reverse operation to buildPath). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52416/#review151021 ----------------------------------------------------------- On Sept. 30, 2016, 5:15 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52416/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 5:15 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > Previously, we pass a 'stripped' cgroup path the parse function. This > is a little confusing to the reader. This patch move the 'strip' logic > to the parse function so that its parameter makes more sense. > > > Diffs > ----- > > src/slave/containerizer/mesos/linux_launcher.cpp > 1bce077e4aa97425b9cbdf8576a5dd52851c044e > > Diff: https://reviews.apache.org/r/52416/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
