-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52480/
-----------------------------------------------------------
(Updated Oct. 3, 2016, 3:16 p.m.)
Review request for mesos, Greg Mann, Artem Harutyunyan, Jie Yu, Timothy Chen,
and Vinod Kone.
Bugs: MESOS-6302
https://issues.apache.org/jira/browse/MESOS-6302
Repository: mesos
Description
-------
Previously, in provisioner recover, we firstly get all container
ids from the provisioner directory, and then find all rootfses
from each container's 'backends' directory. We made an assumption
that if a 'container_id' directory exists in the provisioner
directory, it must contain a 'backends' directory underneath,
which contains at least one rootfs for this container.
However, this is no longer true since we added support for nested
containers. Because we allow the case that a nested container is
specified with a container image while its parent does not have
an image specified. In this case, when the provisioner recovers,
it can still find the parent container's id in the provisioner
directory while no 'backends' directory exists, since all nested
containers backend information are under its parent container's
directory.
As a result, we should skip recovering the 'Info' struct in
provisioner for the parent container if it never provisions any
image.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac f3033e3af722b128256705507dd5dc612eed495f
3rdparty/libprocess/include/process/io.hpp
eec5efd7e6b71a783f2bb40826054d0488cee71f
3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae
3rdparty/libprocess/src/tests/process_tests.cpp
3936f47dfcacb0f85a6fa0f68f1707159b1c320c
3rdparty/libprocess/src/tests/ssl_tests.cpp
55c8c309571b1892b0acc4d766eda9bb98085a6f
3rdparty/stout/configure.ac 527188a71e8dd0d0026d2835b211b3bbfc734292
3rdparty/stout/include/stout/flags.hpp
21257b7ee6ed7a9a48a0ca1ad4edd8890ca2fa8f
configure.ac 8f971c96bfea0afd7462ea9b91c69458324435b6
docs/contributors.yaml c52a9e97bbbd6c16aa0a0de99aaa5e1182d7b2ed
docs/modules.md 701b01fb08d85a1f65adaade2162f8ee787916ae
include/mesos/allocator/allocator.proto
9fc8baccb135c5aa58f64847307978139139a46e
include/mesos/mesos.proto 2a3c251f2f7e1a0decd128e2f7d1720738098aba
include/mesos/state/state.hpp 8f7f3ad0bda029e03d9bdb874cb26add3f888522
include/mesos/v1/allocator/allocator.proto
73d45b37a7afc47366a4a01a36912f30b47c30b1
include/mesos/v1/mesos.proto 57846a5cc0d8af53771346ad4b441ce7b337c6c5
src/Makefile.am c897d863bde284de41c99ed50ccbbdfd2dcad23b
src/cli/mesos.cpp b347f395712da15729563e23b4a05c26434895ac
src/common/resources_utils.cpp c3088433d8c147b06dbef6f310fbe4059c3dc0ba
src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e
src/java/src/org/apache/mesos/state/State.java
2054f59663f3474b868facbba4e7da509812c7c0
src/java/src/org/apache/mesos/state/ZooKeeperState.java
e17f008c1961f94eac7ce4ba6668406df8184b2a
src/master/allocator/mesos/hierarchical.cpp
c8f9492ee1b69e125a1e841116d22a578a9b524e
src/master/master.hpp 6d2b4f54a9e5ec16d304b84ea6c825022ea46d76
src/master/quota_handler.cpp d87d6c6266ba596c4e6bd36124f5a360428fe171
src/slave/containerizer/mesos/containerizer.hpp
eef2cbb033faf9428970369f0434d6653c5d3713
src/slave/containerizer/mesos/containerizer.cpp
e6bd9f7a8284d220be157a3db2da094e6b1b6d33
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
2e722691475c84afae14009014ea70cc0fdd0e65
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
20fb6ab35ffa85917c6705d79f22f0d54a416353
src/slave/containerizer/mesos/isolators/posix.hpp
627004663cbd7223a252b875c51454a20e645be6
src/slave/containerizer/mesos/launcher.cpp
b45313fd717f9553ccb0cbe9e8ac095e2536944a
src/slave/containerizer/mesos/paths.hpp
883cc263c58cf24c3e515dad7bda97efd32f2f17
src/slave/containerizer/mesos/paths.cpp
361307f21422c046672fb7ed29add8fe7e5c4354
src/slave/containerizer/mesos/provisioner/paths.cpp
d9f87e3c82140d25d42d89566def8bac1dc6385a
src/slave/slave.cpp fba089506850eec87f67a46694a1ef645cdf4ad5
src/state/leveldb.cpp 9ced03a4a9f59fd949fc0735b2efcc6711dcfd1a
src/tests/containerizer/nested_container_tests.cpp
8430823d54d132bc3e9c3e0781f027072999683e
src/tests/master_authorization_tests.cpp
5d08ebc5260d380f0fa727f1aee8cad3d0ce1542
src/tests/slave_authorization_tests.cpp
20bb712a65fb58acceeba8bd3d0e56d782e93b5b
Diff: https://reviews.apache.org/r/52480/diff/
Testing
-------
make check
Thanks,
Gilbert Song
