----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/#review151236 -----------------------------------------------------------
src/slave/http.cpp (line 159) <https://reviews.apache.org/r/52471/#comment219552> i would've done changes for this file and the above in a separate review. if there is a test that examines the JSON it is also worth updating. src/webui/master/static/js/app.js (line 42) <https://reviews.apache.org/r/52471/#comment219545> Is this backwards compatible? What if some one is depending on this path to exist? Morever, I think it's worthwhile for people to have access to executor sandbox through the WebUI. Maybe we should keep AgetExecutorRerouteCtrl and add a new AgentTaskRerouterCtrl. src/webui/master/static/js/controllers.js (line 52) <https://reviews.apache.org/r/52471/#comment219548> // Set the task sandbox directory for use by the WebUI. src/webui/master/static/js/controllers.js (line 54) <https://reviews.apache.org/r/52471/#comment219549> s/fill/set/ - Vinod Kone On Oct. 3, 2016, 2:56 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52471/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 2:56 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6283 > https://issues.apache.org/jira/browse/MESOS-6283 > > > Repository: mesos > > > Description > ------- > > For the task launched by default-executor, its sandbox directory is > 'executor_directory/tasks/task_id/'. This patch adds a type to the > state endpoints of agent and generates the corresponding sandbox > directory for the task according to its executor type in Web UI. > > > Diffs > ----- > > src/common/http.cpp 538330a4c780fbc2dfcdfb31537b0e75f368e3e0 > src/slave/http.cpp bdafe1db9f1b22ac0761f5119e73f87b531c6a3c > src/webui/master/static/agent_executor.html > 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 > src/webui/master/static/framework.html > bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b > src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 > src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 > src/webui/master/static/js/controllers.js > 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 > > Diff: https://reviews.apache.org/r/52471/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
