----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/#review151244 -----------------------------------------------------------
src/examples/CMakeLists.txt (lines 84 - 92) <https://reviews.apache.org/r/50327/#comment219563> Why are these necessary? I could build a couple of the example frameworks after deleting these. src/examples/cmake/ExamplesConfigure.cmake (lines 20 - 45) <https://reviews.apache.org/r/50327/#comment219554> s/`-`/`_`/ src/examples/cmake/ExamplesConfigure.cmake (lines 89 - 94) <https://reviews.apache.org/r/50327/#comment219564> Don't see why this is needed. These are all included in `${MESOS_TARGET}`. Most of this `.cmake` file isn't even used :/ - Joseph Wu On Sept. 6, 2016, 3:06 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50327/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 3:06 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added scripts to build sample framework executables. > > > Diffs > ----- > > CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f > cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 > src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 > src/examples/CMakeLists.txt PRE-CREATION > src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/50327/diff/ > > > Testing > ------- > > cmake .. && make dynamic-reservation-framework test-http-framework > test-framework test-executor test-http-executor long-lived-framework > long-lived-executor no-executor-framework docker-no-executor-framework > balloon-framework balloon-executor load-generator-framework > persistent-volume-framework > > > Thanks, > > Srinivas Brahmaroutu > >
