> On Oct. 4, 2016, 9:07 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp, lines 680-682 > > <https://reviews.apache.org/r/52433/diff/1/?file=1516946#file1516946line680> > > > > Can we make it similar to the test you introduce in r/52357? They look > > like they do the same thing.
Ah, I see you do it in r/52434. Why have you decided to split the patches? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52433/#review151397 ----------------------------------------------------------- On Sept. 30, 2016, 5:15 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52433/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 5:15 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Repository: mesos > > > Description > ------- > > Improved the naming of variables in HealthCheckTest.HealthStatusChange. > > > Diffs > ----- > > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52433/diff/ > > > Testing > ------- > > make check GTEST_FILTER="HealthCheckTest.*" V=0 > > > Thanks, > > Gastón Kleiman > >
