----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/#review149834 -----------------------------------------------------------
src/common/resources.cpp (line 146) <https://reviews.apache.org/r/46228/#comment217558> Is there a reason not to include the `principal` field in this equality operator? src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 675) <https://reviews.apache.org/r/46228/#comment218110> either: s/user/the user/ or s/user/`user`/ src/slave/slave.cpp (lines 2488 - 2502) <https://reviews.apache.org/r/46228/#comment217559> Looks like this bit will need some rebasing, since the volume creation code seems to have been factored out into a helper `syncCheckpointedResources`. src/slave/slave.cpp (lines 2494 - 2495) <https://reviews.apache.org/r/46228/#comment217560> Could you enclose the code snippets in backticks? i.e.: `volume.has_disk() && volume.disk().has_persistence()` - Greg Mann On April 14, 2016, 11:04 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46228/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 11:04 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4893 > https://issues.apache.org/jira/browse/MESOS-4893 > > > Repository: mesos > > > Description > ------- > > If user is specified in Resource::DiskInfo::Persistence, set the > ownership of the volume to that user. Tasks should have to comply to > ownership of the volume before they can use the volume. > If user is not specified in Resource::DiskInfo::Persistence, it is > created with the user mesos-slave process runs as. When a task is > launched, it updates the ownership of the persistent volume with its > user so as to be able to write into that persistent volume. > > > Diffs > ----- > > src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 9fc7c48f99155750fd3c18c7c102507e2726362b > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 01c0ad6dbb6d509e62e769365586b3d23dcb240d > src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 > src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a > > Diff: https://reviews.apache.org/r/46228/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
