----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/#review151426 -----------------------------------------------------------
Fix it, then Ship it! Looks good except for the typo, but I haven't tried it personally yet. src/webui/master/static/js/jquery.pailer.js (line 139) <https://reviews.apache.org/r/52042/#comment219758> s/SSS/SS/ - Adam B On Sept. 20, 2016, 12:41 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52042/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 12:41 a.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > ------- > > If attempts to use the pailer to access sandboxes and/or mesos logs fail > because the user is unauthorized, an error telling the user he is > unauthorized is shown to the client instead of showing the misguiding > _Failed to initialize... retrying_. It also disables retry in case the > client is unauthorized. > > > Diffs > ----- > > src/webui/master/static/js/jquery.pailer.js > 79c3c0dad59c2dde78913116bb08383f7a6c4d5e > > Diff: https://reviews.apache.org/r/52042/diff/ > > > Testing > ------- > > `make check` > > and manual tests with the following ACLs > > ```json > { > "permissive": true, > "access_mesos_logs" : [ > { > "principals" : { "values" : ["foo"] }, > "logs" : { "type" : "NONE" } > } > ], > "access_sandboxes" : [ > { > "principals" : { "values" : ["foo"] }, > "users" : { "type" : "NONE" } > } > ] > } > > ``` > > and credentials: > > ``` > foo bar > baz bar > ``` > > > Thanks, > > Alexander Rojas > >
