----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review151442 -----------------------------------------------------------
1) Instead of this fix, can we simply kill https://github.com/apache/mesos/blob/1.0.x/src/tests/hierarchical_allocator_tests.cpp#L782-L783 ? Even without https://github.com/apache/mesos/blob/1.0.x/src/tests/hierarchical_allocator_tests.cpp#L782-L783 , we can still make sure that the agent does not allocate to the origninal framework after filter time out as the filter time out is smaller than the allocation interval. 2) Can you please make your three patch a chain but do not let one patch /r/51027 depend on two patches? A proposal would be /r/51028 -> /r/52534 -> /r/51027 - Guangya Liu On 十月 4, 2016, 11:28 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52534/ > ----------------------------------------------------------- > > (Updated 十月 4, 2016, 11:28 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > - With an asynchronous `batch()` allocation, > this ensures that filters do not expire > before the next allocation. > - This patch should be reverted when allocation > occurs on resource recovery. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > c8f9492ee1b69e125a1e841116d22a578a9b524e > > Diff: https://reviews.apache.org/r/52534/diff/ > > > Testing > ------- > > With https://reviews.apache.org/r/51027/: > > GTEST_FILTER="-*SmallOfferFilter*" make check -j8 > > > Thanks, > > Jacob Janco > >
