> On Oct. 5, 2016, 12:18 a.m., Joseph Wu wrote: > > support/mesos-style.py, lines 270-272 > > <https://reviews.apache.org/r/50910/diff/4/?file=1471508#file1471508line270> > > > > It may help to change the order of reviews (no rebase necessary, just > > the "depends on" field). > > > > Because you add a linter in this review, that depends on the next one ( > > https://reviews.apache.org/r/50912/ ), this review fails to lint itself :)
I'm confused. The order of these patches (and their dependencies) should be correct. This patch "depends on" 50907, not 50912. Also, when I cherry-pick each of these patches onto master individually, they all get linted just as expected. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review151423 ----------------------------------------------------------- On Aug. 11, 2016, 9:54 p.m., Haris Choudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50910/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 9:54 p.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: Mesos-6006 > https://issues.apache.org/jira/browse/Mesos-6006 > > > Repository: mesos > > > Description > ------- > > It currently doesn't run over any files in the code base, but we will > be adding the new python CLI in a subsequent commit, which will use > this new linter. > > > Diffs > ----- > > support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 > > Diff: https://reviews.apache.org/r/50910/diff/ > > > Testing > ------- > > > Thanks, > > Haris Choudhary > >
