----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/#review151489 -----------------------------------------------------------
This test is the same as `HealthyTaskViaHTTPWithoutType` modulo setting type explicitly. I believe it will cause failures descrbed in MESOS-6293. Also, it looks like it subsumes https://reviews.apache.org/r/49435, which should be discarded in this case.In the future, please strive to keep und update old review requests to preserve review history. src/tests/health_check_tests.cpp (line 1405) <https://reviews.apache.org/r/52250/#comment219905> s/Testing/Tests src/tests/health_check_tests.cpp (lines 1413 - 1414) <https://reviews.apache.org/r/52250/#comment219904> Do we really need it in this test? src/tests/health_check_tests.cpp (line 1426) <https://reviews.apache.org/r/52250/#comment219903> This is the default, you can omit this. (I know we are inconsistent). - Alexander Rukletsov On Sept. 29, 2016, 5:43 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52250/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 5:43 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > Added test case `HealthCheckTest.HealthyTaskViaHTTP`. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3 > > Diff: https://reviews.apache.org/r/52250/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
