----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/#review151491 -----------------------------------------------------------
src/tests/health_check_tests.cpp (line 1542) <https://reviews.apache.org/r/52252/#comment219909> s/Testing/Tests src/tests/health_check_tests.cpp (lines 1542 - 1543) <https://reviews.apache.org/r/52252/#comment219917> Let's describe what we are doing. Something like ``` // Tests a healthy docker task via HTTP. To emulate a task responsive // to HTTP health checks, starts Netcat in the docker "alpine" image. ``` src/tests/health_check_tests.cpp (lines 1545 - 1548) <https://reviews.apache.org/r/52252/#comment219914> I see you copy the pattern here, but much cleaner would be to put `new` right under `Shared<>` avoiding a temp pointer. src/tests/health_check_tests.cpp (lines 1597 - 1603) <https://reviews.apache.org/r/52252/#comment219915> Let's pull these comments up before the section. src/tests/health_check_tests.cpp (lines 1607 - 1614) <https://reviews.apache.org/r/52252/#comment219916> Same here, you can put the comment before the section. src/tests/health_check_tests.cpp (line 1613) <https://reviews.apache.org/r/52252/#comment219918> You use Netcat and not Ncat ; ) - Alexander Rukletsov On Sept. 29, 2016, 5:44 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52252/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 5:44 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3 > > Diff: https://reviews.apache.org/r/52252/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
