----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review151498 -----------------------------------------------------------
Similar comments from https://reviews.apache.org/r/52252/ apply here. src/tests/health_check_tests.cpp (lines 1667 - 1668) <https://reviews.apache.org/r/52253/#comment219919> Let's describe what we are doing. Something like ``` // Tests a healthy docker task via TCP. To emulate a task responsive // to TCP health checks, starts Netcat in the docker "alpine" image. ``` - Alexander Rukletsov On Sept. 29, 2016, 5:44 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52253/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 5:44 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3 > > Diff: https://reviews.apache.org/r/52253/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
