----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151500 -----------------------------------------------------------
src/tests/health_check_tests.cpp (lines 1127 - 1128) <https://reviews.apache.org/r/52432/#comment219921> Let's rewrite this comment : ). Please include the short summary about what and how the tests is doing. src/tests/health_check_tests.cpp (line 1155) <https://reviews.apache.org/r/52432/#comment219920> s/This/The src/tests/health_check_tests.cpp (lines 1174 - 1177) <https://reviews.apache.org/r/52432/#comment219922> We usually prepend a comment with a blank line. If you would like to avois this, put the comment at the beginning of the block. - Alexander Rukletsov On Oct. 5, 2016, 1 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52432/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 1 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-1653 > https://issues.apache.org/jira/browse/MESOS-1653 > > > Repository: mesos > > > Description > ------- > > This test was disabled in 2014 because it was considered flaky. I > updated it and ran it 1000 times without a single failure. > > > Diffs > ----- > > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52432/diff/ > > > Testing > ------- > > bin/mesos-tests.sh --verbose --gtest_filter="HealthCheckTest.GracePeriod" > --break-on-error --gtest_repeat=1000 > > > Thanks, > > Gastón Kleiman > >
