----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52162/#review151509 -----------------------------------------------------------
Fix it, then Ship it! Thanks Ilya. Would love to see one little addition to make sure this issues is less likely to occur again - see below. Really confusing how reviewboard displays your patch. So for other reviewers: this really just moves lines 1472-1789 to 1845 - effectively making sure that all mutations towards the `LDFLAGS` (and others) are indeed captured by the disttools invocations needed for those eggs. configure.ac (line 1845) <https://reviews.apache.org/r/52162/#comment219929> Can we please add one additional comment here; something like: ``` # NOTE: Do not update any compiler or linker settings (e.g. CXXFLAGS, # LDFLAGS, ...) beyond this line. ``` Feel free to change the wording as I am not a native speaker :) - Till Toenshoff On Oct. 5, 2016, 1:45 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52162/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 1:45 p.m.) > > > Review request for mesos, Benjamin Bannier, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6207 > https://issues.apache.org/jira/browse/MESOS-6207 > > > Repository: mesos > > > Description > ------- > > Moved Python related configuration steps down below all others. Now > PYTHON_LDFLAGS variable captures all required LDFLAGS. > > > Diffs > ----- > > configure.ac 57482d39db1f83e92e75fca959cd6df329a1c24f > > Diff: https://reviews.apache.org/r/52162/diff/ > > > Testing > ------- > > ``` > ../configure --with-svn=$HOME/svn && make && make check > ``` > > > Thanks, > > Ilya Pronin > >
