----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/#review151516 -----------------------------------------------------------
src/common/protobuf_utils.hpp (line 188) <https://reviews.apache.org/r/52515/#comment219946> 2 empty lines please. src/common/protobuf_utils.hpp (line 192) <https://reviews.apache.org/r/52515/#comment219947> Ditto src/common/protobuf_utils.cpp (line 498) <https://reviews.apache.org/r/52515/#comment219933> hmm, this is a bit inconsistent. We have been using `model()` functions historically to convert our internal protos into `JSON` based responses. I guess you did it like this since the logic was previously common to both the helper functions that you had added? How do you feel about adding a helper function `createAgentResponse()` instead in a separate review and make `_getAgents()` invoke it? This would avoid duplicating this code at both the places. Then in this review you can make `createAgentAdded()` invoke it? src/common/protobuf_utils.cpp (line 547) <https://reviews.apache.org/r/52515/#comment219939> s/Slave/SlaveID? Looks like you are using `AgentInfo` in the `AGENT_REMOVED` event. We need to *change* it to `AgentID` as per my review comment in the previous review. - Anand Mazumdar On Oct. 5, 2016, 3:30 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52515/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 3:30 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-6102 > https://issues.apache.org/jira/browse/MESOS-6102 > > > Repository: mesos > > > Description > ------- > > Implement `AGENT_ADDED` and `AGENT_REMOVED` events. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 0c6405f6cfc5a69fa835428fa330d8d63778f469 > src/common/protobuf_utils.cpp 1f088684c566f89c85dd72eaece295c5e3d50b23 > src/master/master.cpp 756ab546851952bc1de24b1f469d232237b1c01c > > Diff: https://reviews.apache.org/r/52515/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
