----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review151644 -----------------------------------------------------------
Fix it, then Ship it! Thanks for the cleanup! I suggested an alternative wording for most of the tests descriptions. src/tests/health_check_tests.cpp (line 230) <https://reviews.apache.org/r/52563/#comment220087> ``` // This test creates a healthy task and verifies that the healthy status is // reflected in the status updates sent as reconcilliation answers, and in the // state endpoint of both the master and the agents. ``` src/tests/health_check_tests.cpp (line 354) <https://reviews.apache.org/r/52563/#comment220080> ``` // This test creates a healthy task and verifies that the healthy status is // reflected in the status updates sent as reconcilliation answers, and in the // state endpoint of both the master and the agents. ``` src/tests/health_check_tests.cpp (line 470) <https://reviews.apache.org/r/52563/#comment220081> ``` // This test creates a healthy task using the Docker executor and verifies that // the healthy status is reflected in the status updates sent as // reconcilliation answers, and in the state endpoint of both the master and // the agents. ``` src/tests/health_check_tests.cpp (line 640) <https://reviews.apache.org/r/52563/#comment220082> ``` // This test creates a task whose health flaps, and verifies that the health // status updates are sent to the framework and reflected in the state endpoint // of both the master and the slaves. ``` src/tests/health_check_tests.cpp (line 833) <https://reviews.apache.org/r/52563/#comment220083> ``` // This test creates a task that uses the Docker executor and whose health // flaps. It then verifies that the health status updates are sent to the // framework and reflected in the state endpoint of both the master and the // slaves. ``` src/tests/health_check_tests.cpp (line 979) <https://reviews.apache.org/r/52563/#comment220084> ``` // This test ensures that a task is killed if the number of maximum health // check failures is reached. ``` src/tests/health_check_tests.cpp (line 1055) <https://reviews.apache.org/r/52563/#comment220085> ``` // Tests that the task's env variables are copied to the env used to execute // COMMAND health checks. ``` src/tests/health_check_tests.cpp (line 1163) <https://reviews.apache.org/r/52563/#comment220086> ``` // This test creates a task with a health check command that will time out, and // verifies that the health check is retried after the timeout. ``` - Gastón Kleiman On Oct. 5, 2016, 6:11 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52563/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 6:11 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > * Replace `Testing` to `Tests` in comments. > * Remove redundant `.Times(1)`. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52563/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest.*" > --gtest_also_run_disabled_tests > [----------] Global test environment tear-down > [==========] 19 tests from 1 test case ran. (35264 ms total) > [ PASSED ] 19 tests. > ``` > > > Thanks, > > haosdent huang > >
