----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52604/#review151661 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52604/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 2:58 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The template `flags::Flags` allowed to compose flags classes on the > fly, e.g., > > flags::Flags<MyFlags1, MyFlags2> flags; > > which would create a class inheriting virtually from both `MyFlags1` > and `MyFlags2`. > > This class was not used in the code. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags.hpp > 21257b7ee6ed7a9a48a0ca1ad4edd8890ca2fa8f > 3rdparty/stout/include/stout/flags/flags.hpp > eab8a001ed19755de58386a55ed4972f58026b29 > 3rdparty/stout/tests/flags_tests.cpp > 94ba915c40836e476cf6097274a85c55acd4d73b > > Diff: https://reviews.apache.org/r/52604/diff/ > > > Testing > ------- > > * `git grep 'Flags<'` > * tested as part of the review chain ending in > https://reviews.apache.org/r/52388/ on various Linux configurations in > internal CI. > > > Thanks, > > Benjamin Bannier > >
