----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/#review151696 -----------------------------------------------------------
include/mesos/master/master.proto (line 465) <https://reviews.apache.org/r/52347/#comment220152> s/task_status/status We have been just using "status" historically everywhere for `TaskStatus`. include/mesos/master/master.proto (line 467) <https://reviews.apache.org/r/52347/#comment220159> Move this comment before L465 since `status` is the task status corresponding to the last status update acked by the scheduler. Also consider rewording this to: ```cpp // This is the status of the task corresponding to the last status update acknowledged by the scheduler. ``` include/mesos/master/master.proto (line 468) <https://reviews.apache.org/r/52347/#comment220162> Since we would be moving the comment in L467 above L465, can we add a comment for this field too? src/common/protobuf_utils.hpp (line 170) <https://reviews.apache.org/r/52347/#comment220173> s/last acknowledged state from scheduler/latest state src/common/protobuf_utils.hpp (line 171) <https://reviews.apache.org/r/52347/#comment220174> s/recently updated status/last status update acknowledged by the scheduler src/master/master.cpp (line 7483) <https://reviews.apache.org/r/52347/#comment220170> How about: ```cpp // Indicated whether we should send a notification to all subscribers if the task transitioned to a new state. ``` and killing the comment on L7533 src/master/master.cpp (line 7539) <https://reviews.apache.org/r/52347/#comment220171> hmm, a subscriber might be interested in the `data` field too which gets removed in L7531? - Anand Mazumdar On Oct. 6, 2016, 5:13 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52347/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 5:13 a.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Vinod Kone. > > > Bugs: MESOS-5936 > https://issues.apache.org/jira/browse/MESOS-5936 > > > Repository: mesos > > > Description > ------- > > Review: https://reviews.apache.org/r/52347 > > > Diffs > ----- > > include/mesos/master/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db > include/mesos/v1/master/master.proto > 58dc65006658f47bb752ee1c0c1520ee3cc03bd7 > src/common/protobuf_utils.hpp c5e5a9ad10134bcf87b59460bec7152e4916c75d > src/common/protobuf_utils.cpp 3ff37f498d6c830eb2f4b3d9395f9416cb01f5d3 > src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 > src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c > > Diff: https://reviews.apache.org/r/52347/diff/ > > > Testing > ------- > > unit test. > > > Thanks, > > Zhitao Li > >
