> On Oct. 6, 2016, 7:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 230 > > <https://reviews.apache.org/r/52539/diff/1/?file=1522501#file1522501line230> > > > > Use `const` if sounds good to you.
I just make things consistent. If we want to use const, why not for others like ContainerID, FrameworkID, etc.? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52539/#review151706 ----------------------------------------------------------- On Oct. 5, 2016, 1:15 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52539/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 1:15 a.m.) > > > Review request for mesos, Benjamin Hindman and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > Refactored and simplified LinuxFilesystemIsolatorTests. > > > Diffs > ----- > > src/tests/containerizer/filesystem_isolator_tests.cpp > 5b6a1d409293e8d16f6bd78bc9c6f5a524c5e0fe > src/tests/mesos.hpp a05e3e0fad92169dc550f1a1a8b704074716d99e > > Diff: https://reviews.apache.org/r/52539/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
