----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52615/#review151749 -----------------------------------------------------------
Ship it! LGTM - Anand Mazumdar On Oct. 6, 2016, 7:38 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52615/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 7:38 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6319 > https://issues.apache.org/jira/browse/MESOS-6319 > > > Repository: mesos > > > Description > ------- > > This allows callers to "reap" containers that are already terminated, > mimicing the behavior of the mesos containerizer. > > This also fixes MESOS-6319, where the `wait()` could occur after a > `destroy()` had already completed. > > > Diffs > ----- > > src/tests/containerizer.hpp 0ffba7397e844f863652fc6c6e03b8d2b47e717d > src/tests/containerizer.cpp 3affa0ff8a348df91f7a56c318df2786ee5dea0b > > Diff: https://reviews.apache.org/r/52615/diff/ > > > Testing > ------- > > $ ./bin/mesos-tests.sh --gtest_filter="*AgentAPITest.NestedContainer*" > --gtest_repeat=-1 --gtest_break_on_failure > > > Thanks, > > Benjamin Mahler > >
