----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52622/#review151815 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1824) <https://reviews.apache.org/r/52622/#comment220359> return EXIT_FAILURE? ALso, errno here does not apply. - Jie Yu On Oct. 7, 2016, 4:41 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52622/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 4:41 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6324 > https://issues.apache.org/jira/browse/MESOS-6324 > > > Repository: mesos > > > Description > ------- > > Earlier we were setting up the `pre_exec_command` for the executor > with `ifconfig lo up`. This had a drawback that it assumes that PATH > set for the executor would have `ifconfig`. Unfortunately, it turns > out in most cases the executors PATH is a subset of the agents path > and hence there is a high probability that the executors shell will > not be able to find `ifconfig`. > > Instead we bring up the loopback during the setup of network files in > the `NetworkCniIsolatorSetup` subcommand. The subcommand is run with > the agents PATH variable so chances that ifconfig is not present in > the path are much less. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > d530a364567ae1fbfdcde921eb109acda6667c39 > > Diff: https://reviews.apache.org/r/52622/diff/ > > > Testing > ------- > > make and make check > > Also ran a single node cluster on Ubuntu 14.04 to make sure that pods have lo > up in their network namespace when join a CNI bridge network. > > > Thanks, > > Avinash sridharan > >
