----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51033/#review151856 -----------------------------------------------------------
Looks pretty good, ditto my comments from the previous review. - Benjamin Mahler On Oct. 6, 2016, 10:20 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51033/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 10:20 a.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Added validation benchmark test for resources. > > > Diffs > ----- > > src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a > > Diff: https://reviews.apache.org/r/51033/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*Resources_Validate_BENCHMARK_Test.Validate/*" > [==========] Running 4 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 4 tests from ResourcesValidate/Resources_Validate_BENCHMARK_Test > [ RUN ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/0 > Took 2664us to perform 5000 'validate(r)' operations on cpus(*):1; gpus(*):1; > mem(*):128; disk(*):256 > [ OK ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/0 > (2 ms) > [ RUN ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/1 > Took 4842us to perform 5000 'validate(r)' operations on cpus(role1):1; > gpus(role2):1; mem(*):128; disk(... > [ OK ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/1 > (5 ms) > [ RUN ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/2 > Took 11.511985secs to perform 5000 'validate(r)' operations on ports(*):[1-2, > 4-5, 7-8, 10-11, 13-14, 16-17, 1... > [ OK ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/2 > (11513 ms) > [ RUN ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/3 > Took 1704us to perform 5000 'validate(r)' operations on > disk(role)[PATH:mnt,2:path]:10 > [ OK ] ResourcesValidate/Resources_Validate_BENCHMARK_Test.Validate/3 > (1 ms) > [----------] 4 tests from ResourcesValidate/Resources_Validate_BENCHMARK_Test > (11521 ms total) > > [----------] Global test environment tear-down > [==========] 4 tests from 1 test case ran. (11531 ms total) > [ PASSED ] 4 tests. > ``` > > > Thanks, > > Guangya Liu > >
