----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52690/#review152009 -----------------------------------------------------------
Patch looks great! Reviews applied: [52690] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 10, 2016, 12:59 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52690/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 12:59 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5656 > https://issues.apache.org/jira/browse/MESOS-5656 > > > Repository: mesos > > > Description > ------- > > We depend on certain artifacts in built 3rdparty components. With the > make generator just defining it appears just defining an external > project is good enough since make just uses these as order-only > targets. With the ninja generator on the other hand this appears to be > insufficient as its dependency graph analysis detects that 3rdparty > libraries we are about to link against do not exist and no explicit > rule defines a recipe exists to generate them. > > This commits adds BUILD_BYPRODUCTS clauses for zookeeper and leveldb. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d > > Diff: https://reviews.apache.org/r/52690/diff/ > > > Testing > ------- > > `ninja test` > > > Thanks, > > Benjamin Bannier > >
