-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/
-----------------------------------------------------------

(Updated Oct. 10, 2016, 6:13 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Move some of the warnings that were set in MESOS_CPPFLAGS to AM_CXXFLAGS.


Bugs: MESOS-6229
    https://issues.apache.org/jira/browse/MESOS-6229


Repository: mesos


Description
-------

Use a default set of flags to provide additional security and hardening to 
Mesos. Additionally, check and catch more warnings/errors.


Diffs (updated)
-----

  configure.ac 034bb91 
  src/Makefile.am fd01e1d 

Diff: https://reviews.apache.org/r/52645/diff/


Testing
-------

Compared the benchmarks with and without the flags being used. Also did a 
comparsion with the flags being used with and without optimizations and without 
the flags being used with and without optimizations. Overall the performance 
hit was very small with a 3-8% overhead (optimizations brings this down 
slightly). Most benchmarks were about 5% (or less) slower.


Thanks,

Aaron Wood

Reply via email to