----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52680/#review152074 -----------------------------------------------------------
Ship it! This looks right to me, I'll Jie comment and merge though. - Timothy Chen On Oct. 10, 2016, 10:06 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52680/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 10:06 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > When force pull docker image, we should use the full docker image > name to avoid pulling down the repository. > > Seems the latest docker client will add `latest` automatically > for now but I think that we still need to keep the logic in case > someone using old docker client. > > > Diffs > ----- > > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/52680/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
