> On Oct. 10, 2016, 6:54 p.m., Vinod Kone wrote: > > I think it's probably worth to just mutate TaskInfo like you did in the > > very first diff rather than doing all these changes. They are bit messy and > > incomplete. > > haosdent huang wrote: > Let's use mutating way.
I drop following issues because use the mutating way now. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152034 ----------------------------------------------------------- On Oct. 11, 2016, 6:06 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52470/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 6:06 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6283 > https://issues.apache.org/jira/browse/MESOS-6283 > > > Repository: mesos > > > Description > ------- > > This fixed the navigate error in Web UI because Web UI uses the > executor id of the task to search the corresponding sandbox directory. > Web UI uses the task id as the executor id if the executor id of the > task is empty when searching the sandbox directory. It works fine when > tasks are launched by `CommandExecutor` because the executor id of the > task is equal to the task id in this case. However, when tasks are > launched by `DefaultExecutor`, the executor id of the task is defined > in the framework side and may different with the task id. So we need to > fill the `ExecutorInfo` of the `TaskInfo` when `LAUNCH_GROUP` to avoid > the Web UI uses incorrect executor id to search sandbox directory. > > > Diffs > ----- > > src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 > > Diff: https://reviews.apache.org/r/52470/diff/ > > > Testing > ------- > > Add a new test case `CommandExecutorTest.EmptyExecutorIdInTask`. > > > Thanks, > > haosdent huang > >
